Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| hasPermission([RoleConst.ADMIN, PermissionConst.RESOURCE_MODEL_DELETE], 'OR'), | ||
|
|
||
| folderCreate: () => false, | ||
| folderEdit: () => false, |
There was a problem hiding this comment.
There are no obvious issues in the provided code snippet. However, there is one minor improvement:
// Add type annotations to parameters
modify: (id: string) =>
hasPermission([RoleConst.ADMIN, PermissionConst.RESOURCE_MODEL_EDIT], 'OR'),
paramSetting: (id: string) =>
hasPermission([RoleConst.ADMIN, PermissionConst.RESOURCE_MODEL_EDIT], 'OR'),
delete: (id: string) =>
hasPermission([RoleConst.ADMIN, PermissionConst.RESOURCE_MODEL_DELETE], 'OR');Adding type annotations (string and Permission) helps clarify what the function expects as input and can enhance readability for other developers working with this code.
1 participant
build: Packaging error